search

kadirnar / strongsort-pip

StrongSort-Pip: Packaged version of StrongSort
MIT License
13 stars 2 forks source link

Remove dev dependencies from requirements.txt #1

Closed franklinselva closed 1 year ago

franklinselva commented 1 year ago

Hi,

Setting up PyPi releases for strong_sort is really helpful. Thank you for starting it out.

I found that in version 0.2.0, there are dev dependencies as part of requirements.txt. I am not sure if it is helpful to the library itself. I would like to check with you for removing the possibility the unnecessary packages from the release version.

kadirnar commented 1 year ago

Hello @franklinselva

Thank you for your interest in the library. Are you referring to the Black and Isort libraries?

franklinselva commented 1 year ago

Yes. I am. Could we remove these packages from library dependencies? If needed, I could also contribute to the package.

kadirnar commented 1 year ago

That would be great. If you open a Pull Request I can accept it. You can make this change to other repos as well.

https://github.com/kadirnar/TrackerHub https://github.com/kadirnar/ocsort-pip https://github.com/kadirnar/sort-pip https://github.com/kadirnar/bytetrack-pip

franklinselva commented 1 year ago

Thank you. I will check with your other works too. I will add a PR for the new changes.