kadiryazici / bottom-sheet-vue3

Bottom sheet component for Vue3.
https://kadiryazici.github.io/bottom-sheet-vue3/
MIT License
29 stars 6 forks source link

Scrollable content and fullscreen step #24

Open RoyvanEmpel opened 4 months ago

RoyvanEmpel commented 4 months ago

Version (Required):

Environment (Required):

Issue explanation (Required): Would it be possible to create a sort of step/spots system like mentioned in this comment: https://github.com/kadiryazici/bottom-sheet-vue3/issues/2#issuecomment-1336612065

It would be nice to have a spot thats for example 40 dvh and then one thats 100 dvh for a fullscreen mode. The animations and swiping (inside and outside the sheet) works amazing currently.

We are having difficulties with scrollable / longer content. Atm it simply just graps the sheet and you can temporarily make it bigger / smaller.

kadiryazici commented 4 months ago

I got it, you want a base height and then if user starts to scroll sheet will be bigger, when the sheet becomes full screen it will let the inner content to scroll.

kadiryazici commented 4 months ago

Oh gosh, I now want to rewrite the library again :D 2 year old me wasn't close to current one.

RoyvanEmpel commented 4 months ago

I got it, you want a base height and then if user starts to scroll sheet will be bigger, when the sheet becomes full screen it will let the inner content to scroll.

Yes thats exactly what I meant. Do you think it's possible for something like this to be added to the current version?

kadiryazici commented 4 months ago

I think so but curently I am busy

kadiryazici commented 4 months ago

@RoyvanEmpel and btw if I rewrite the library nothing will change, props and behavior will be the saem

RoyvanEmpel commented 4 months ago

Oh okay, so no inner scroll / steps? Or do you mean that you wil keep backwards compatibility for projects with the current version?

kadiryazici commented 4 months ago

I will try to implement steps but my first target will be prevent scroll until hit top of the page. Yea it will be a path or minor update not a major one