Improve updating props and reliability

kadoshms / react-jvectormap

A react wrapper for jvectormap maps

MIT License

98 stars 70 forks source link

Improve updating props and reliability #58

Closed crsohr closed 3 years ago

crsohr commented 4 years ago

Previously updating the “map” property was not supported, this PR fixes this issue. In addition, React 16 deprecates componentWillMount, this updates the code to use componentDidUpdate, which suppresses the warning on the console.

lukasa1993 commented 4 years ago

why this isn't merged any problems ?

crsohr commented 3 years ago

@kadoshms was there an issue with this PR? looks like code in master still doesn't support when the map property changes

kadoshms commented 3 years ago

@crsohr thanks for you contribution! I'm working on a new version with a completly new API, and tons of fixes.