search

kadyb / rgugik

Download datasets from Polish Head Office of Geodesy and Cartography
https://kadyb.github.io/rgugik/
Other
33 stars 4 forks source link

added information about the date #42

Closed BERENZ closed 4 years ago

BERENZ commented 4 years ago

In this pull request I include information about the date of aerial or satellite photos based in akt_data variable available in GUGIK API. This information is crucial if you work with time series data and you would like to know for exactly what period these ortophotomaps are vaild.

kadyb commented 4 years ago

Thanks for contributing!

  1. Could you change the order of the columns to match the GUGiK database? akt_data should be after sha1. #akt_data = numeric() in 58 line should be uncommented. I think it will make easier to detect some errors if something will change on the server side.
  2. Could you update test in test-orto_request.R? Now we expect 12 columns as the output.

Note that the older orthophotomaps don't have an exact date (it will always be 01 January).

BERENZ commented 4 years ago

Done. Hope this is what you expected.

kadyb commented 4 years ago

Yeah. Please change order in selected_cols too (26-28 lines).

kadyb commented 4 years ago

Thanks!