implement tryGet for all funs

kadyb / rgugik

Download datasets from Polish Head Office of Geodesy and Cartography

https://kadyb.github.io/rgugik/

Other

33 stars 4 forks source link

implement tryGet for all funs #51

Closed kadyb closed 3 years ago

kadyb commented 3 years ago

[x] Fix code.
[x] Update tests.

kadyb commented 3 years ago

@Nowosad Please review and test. I did 10 tests with an internet connection and 10 without (i.e. disconnections) and everything worked. Definitely, this is not a perfect solution, but it works, so we can try get into CRAN.

Nowosad commented 3 years ago

My quick tests worked fine!

kadyb commented 3 years ago

Nice. Should I merge it now or wait for more tests from you? No hurry. Let be sure that it will meet the CRAN expectations.

Nowosad commented 3 years ago

I would suggest trying to submit to CRAN now. If there is still something wrong with the package - the CRAN team will let us know.

kadyb commented 3 years ago

More advanced connection checking function (test_URL()) can be found here: https://github.com/kadyb/rgugik/pull/21 but isn't working satisfactorily, requires further work.