search

kadyb / rgugik

Download datasets from Polish Head Office of Geodesy and Cartography
https://kadyb.github.io/rgugik/
Other
33 stars 4 forks source link

remove spaces in URL (fixes #83) #84

Closed kadyb closed 2 years ago

Nowosad commented 2 years ago

It works on my example (I also fixed broken/outdated urls).

kadyb commented 2 years ago

Most of these links don't work now (redirect to https://www.gov.pl/). Only http://www.gugik.gov.pl should be change to https://www.gov.pl/web/gugik, the rest should stay the same.

Check:

Before: http://www.gugik.gov.pl/pzgik/zamow-dane/numeryczny-model-terenu
After: https://www.gov.pl/web/gugik/pzgik/zamow-dane/numeryczny-model-terenu
kadyb commented 2 years ago

vignettes/DEM.Rmd <- if I remember correctly, the change should be made in DEM.Rmd.orig becouse we generate Rmd files using vignettes/PRECOMPILE.R script

Nowosad commented 2 years ago

Thanks for checking the links. I think some of them should be fixed before CRAN submission, but this is a different issue. I reverted most of the changes now.

kadyb commented 2 years ago

Ok, so I will merge this as is. Maybe let's wait for the release on CRAN because I think #81 should be fixed too (+ these links).