search

kadyb / rgugik

Download datasets from Polish Head Office of Geodesy and Cartography
https://kadyb.github.io/rgugik/
Other
33 stars 4 forks source link

CRAN issue #92

Closed kadyb closed 2 years ago

kadyb commented 2 years ago

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_rgugik.html.

In particular, please see the "Found the following HTML validation problems" NOTEs in the "HTML version of manual" check for the r-devel debian checks results.

R 4.2.0 switched to use HTML5 for documentation pages. Now validation using HTML Tidy finds problems in the HTML generated from your Rd files of the form

element removed from HTML5

element removed from HTML5 attribute "align" not allowed for HTML5 attribute "hspace" not allowed for HTML5 attribute "width" has invalid value "120px" attribute "width" has invalid value "480px" attribute "width" has invalid value "50px" attribute "width" has invalid value "72px" For the first four, please see for info on these: in principle, all can be fixed by using style attributes, e.g. style='text-align: right;' instead of align='right' etc., which will work for both the new and old ways of converting Rd to HTML. For the second four, simply drop the px units: the HTML5 standard asks for a non-negative integer implied to be in CSS pixels.
kadyb commented 2 years ago

https://github.com/DavisVaughan/extrachecks-html5

Nowosad commented 2 years ago

I had the same issue with the {sabre} package (https://cran.r-project.org/package=sabre) -- installing roxygen2 version 7.2.1 and updating the documentation (and bumping the package version) was enough to fix it.

install.packages("roxygen2")
devtools::document()
kadyb commented 2 years ago

I fixed it in the last commits. I also tried to fix one line in README, but GitHub doesn't support CSS, so I reverted this change (26f0666). The new version is on CRAN.