Skip Notes Instead of Cards

kaegi / MorphMan

Anki plugin that reorders language cards based on the words you know

Other

262 stars 66 forks source link

Skip Notes Instead of Cards #146

Open ohare93 opened 4 years ago

ohare93 commented 4 years ago

Fixes #106.

Cards should only be skipped if all the cards on that note are also skipped. If one card is learned, the other cards should be too. See the above issue for examples.

This is a simple fix, that is far from perfect. Though @AtilioA has also tested it, so it does work at least.

Possible Improvements:

Add a hefty bonus to each card of a note with any learned cards. This will keep the other cards from falling down into the queue after the morph has been learned. I do not believe I have experienced this, but I can see it is a possibility.
Make this a config option. I personally cannot see a reason why someone would want to skip subsequent card types, surely they'd just remove the card type they never study? Though if others want it I could add a togglable option for this.

All feedback welcome :+1:

ohare93 commented 4 years ago

@landonepps I noticed the add-on on AnkiWeb was recently updated with your fork of Morphman linked for the changeset, where you have pulled this PR. Is this repo of @kaegi's not the official place to submit fixes? Or is your repo simply for 2.1 and this one is for 2.0, and I have missed some documentation.

Regardless, good stuff on pulling it in there to the actual add-on :+1: :clap: ping the relevant PR/issue for some well deserved kudos next time :wink:

landonepps commented 4 years ago

Yeah, I don't have write access to this repository, so I'm unable to create tags for releases or merge PRs. As a workaround, I figured I could merge them into my fork and use the commit log for the tag to show exactly what changes made it into the release.

But for future changes please continue to use kaegi/MorphMan. I don't want things to get fragmented.

ohare93 commented 4 years ago

Updated PR to also not skip cards marked as Comprehension if any of the cards in the note have already been studied. This was an oversight on my part, as my previous fix will only stop Morphman from skipping new cards. Just a one liner, and it works well on my system (I have 1000 or so 'Comprehension' cards to catch up with now!)

@AtilioA

AtilioA commented 4 years ago

I've too only noticed a few days ago and I have about the same number 😅. I'll edit this into my Morphman and see how it goes.

ohare93 commented 4 years ago

I've too only noticed a few days ago and I have about the same number . I'll edit this into my Morphman and see how it goes.

Great minds ~~think alike~~ notice bugs are the same time! :sweat_smile: :grin: