kaegi / MorphMan

Anki plugin that reorders language cards based on the words you know
Other
262 stars 66 forks source link

Update of morphman to anki version 2.1.35 #178

Closed dmgerman closed 4 years ago

dmgerman commented 4 years ago
dmgerman commented 4 years ago

Thanks. I'll clean up the changes. Some issues are because I wrote commits that overrode previous commits. I tried to squash almost everything related. Let me create a new pull request where I address your comments. And clean up the old code.

about the IgnoreBrackets options. I'll profile it and see what is better. I assume speed is more important than memory.

joestrong commented 4 years ago

I have done some PRs recently that helps improve some features for at least 2.1.26 too, including the brackets feature, batch play etc. if anyone wants to take a look?

Not sure who the maintainers are here, who can merge etc.

ianki commented 4 years ago

I have done some PRs recently that helps improve some features for at least 2.1.26 too, including the brackets feature, batch play etc. if anyone wants to take a look?

Not sure who the maintainers are here, who can merge etc.

I can push to the main repo, if you want to send PRs.

joestrong commented 4 years ago

I have done some PRs recently that helps improve some features for at least 2.1.26 too, including the brackets feature, batch play etc. if anyone wants to take a look?

Not sure who the maintainers are here, who can merge etc.

I can push to the main repo, if you want to send PRs.

Yeah, the most recent 4 PRs before this one are me! Also this one fixes a recent bug: https://github.com/kaegi/MorphMan/pull/174

ianki commented 4 years ago

joestrong has already added round bracket support & tests to https://github.com/kaegi/MorphMan/pull/175.

Should we just merge that?