search

kaegi / MorphMan

Anki plugin that reorders language cards based on the words you know
Other
262 stars 66 forks source link

Bump maximum version to 2.1.53 #273

Closed ghost closed 1 year ago

ghost commented 2 years ago

There are not breaking changes in 2.1.53 to modify this.

rwmpelstilzchen commented 2 years ago

Does it really works without problems with 2.1.53? The AnkiWeb page has this warning, and no update to MorphMan has been made since:

**Warning**
Anki 2.1.50 changed a lot of things under the hood, breaking compatibility with MorphMan.
Use version 2.1.49 in the meanwhile: https://github.com/ankitects/anki/releases/tag/2.1.49

CC: @ianki

ghost commented 2 years ago

I didn't even see that notice! Haven't got any problems thus far, although they're probably hidden to me as I'm no expert. Morphman does work though. Even in 2.1.54

rwmpelstilzchen commented 2 years ago

Good to hear :-)

I don’t need to use MorphMan at the moment¹, but when I do I will test that on my system as well. It’s not the first time a certain version of Anki breaks things with add-ons, but later versions work just fine.

¹ I avoid learning any new cards until my PhD dissertation is submitted… 📚

rameauv commented 2 years ago

the stats counter in the toolbar is not working. The link in the toolbar seems to be added with a hook ("top_toolbar_did_redraw") and the morphman preferences are loaded also via a hook ("addHook('profileLoaded', init_preferences)"). The problem seems to be that the toolbar hook is called before the preferences hook and the stats cannot be loaded. I would like to contribute in this project if possible. Still trying to understand the code.

rwmpelstilzchen commented 2 years ago

Thanks, @rameauv! ^_^

ghost commented 2 years ago

That's strange about the toolbar. Working for me in 2.1.54 and it never stopped working...

rameauv commented 2 years ago

I'm on macos v12.3.1, with anki 2.1.54 qt5

ghost commented 2 years ago

Could be a Mac/qt5 related problem

landonepps commented 2 years ago

There are at least 2 known issues with 2.1.50 and newer. If it works fine on your system, then feel free to download the zip file and install it manually. This is the same file hosted by AnkiWeb. To make things easier for less tech savvy users, I won't update the version on AnkiWeb until it's fully supported.

Also @rameauv we'd love to have your help! I don't have a ton of time to make contributions, right now I just work to keep AnkiWeb updated with whatever contributions the community (mainly ianki, recently) makes.

rwmpelstilzchen commented 2 years ago

I finished writing my dissertation, so I can relax a bit my Anki ‘abstinence’ and check MorphMan. So far, I encountered no problems with this version on Anki version ⁨2.1.54 (b6a7760c)⁩ running on Linux.

rwmpelstilzchen commented 2 years ago

Well, there are problems with the v3 scheduler (#276), but this seems unrelated to the version of Anki. I tested this on both 2.1.49 and 2.1.54, with the same results: MorphMan’s automatic skipping works on v2 but not on v3.

Vilhelm-Ian commented 2 years ago

The fact that morphman dosen't automatically skip words is not a problem. You can just press ctrl+M to manually skip

rwmpelstilzchen commented 1 year ago

The fact that morphman dosen't automatically skip words is not a problem. You can just press ctrl+M to manually skip

This should be done automatically. Doing so manually is unnecessary and laboursome.

rameauv commented 1 year ago

@rwmpelstilzchen I made a pull request to fix the bug I talked about. This bug is also referenced here https://github.com/kaegi/MorphMan/issues/262

landonepps commented 1 year ago

AnkiWeb is officially updated to the new v5.0 alpha. https://github.com/kaegi/MorphMan/releases/tag/v5.0-qt6-alpha.1 Thanks @rameauv for the toolbar fix.

If you come across any new bugs with the pre-release version please create an issue.