kaegi / MorphMan

Anki plugin that reorders language cards based on the words you know
Other
260 stars 66 forks source link

V3 compatible, Recalc improved, progress bars fixed #296

Closed mortii closed 1 year ago

mortii commented 1 year ago
mortii commented 1 year ago

I fixed the lint errors and I rebased onto qt6-migration

mortii commented 1 year ago

hold on, a very a sneaky error appeared that needs to be fixed

mortii commented 1 year ago

there was an invisible input parameter after removing a lambda, but it's fixed now.

mortii commented 1 year ago

Also this should probably be placed in the ankiweb description until we get a proper wiki/guide (next on my todo-lis):

NB! If the deck you are studying has sub-decks then new cards will by default only be gathered from the first sub-deck until it is empty before looking for new cards in the next sub-deck. If you instead want to get new i+1 cards from all sub-decks do the following:

  1. Activate the v3 scheduler: Tools -> Review -> Scheduler -> V3 scheduler
  2. Deck that has sub-decks: Deck options -> Display Order -> New card gather order -> Ascending position

The writing is kinda clunky, feel free to improve it in whatever way you see fit , lol.

landonepps commented 1 year ago

Looks good to me, thanks for all the work you did here. And I appreciate the AnkiWeb note, I'll be sure to add it.

PrentissLiu commented 1 year ago

Thank you so much for your work. I am the version of QT5. I tried to modify: readability_ui.py and readability_settings_ui.py :

from PyQt6 import QtCore, QtGui, QtWidgets

to:

from PyQt5 import QtCore, QtGui, QtWidgets

it works!

landonepps commented 1 year ago

Awesome, I really appreciate the report! Both of my computers are arm-based Macs, which don't support Qt5, making it quite annoying to test.

If this is really all that's needed, I should be able to modify the UI generation code to replace these imports with the aqt version and have full backwards compatibility.