search

kaegi / alass

"Automatic Language-Agnostic Subtitle Synchronization"
GNU General Public License v3.0
1.03k stars 52 forks source link

State of `download_subtitles_for_movie.py` #4

Open CosmicHorrorDev opened 5 years ago

CosmicHorrorDev commented 5 years ago

Is download_subtitles_for_movie.py still being used, and if so would you mind someone going through and cleaning the code following the styling format of something like flake8 and/or black (black and flake8 do have different default line lengths (79 -> flake8, 100 -> black) so normally one standard is picked since black will format lines to be longer than flake8 allows).

There are also some other changes that could be made to clean up the code, but I'm not sure if it is still actively being used.

kaegi commented 5 years ago

I'm currently rewriting nearly everything in that file to create a usable database for statistics (so it is still used!!). Doing a merge currently will only lead to conflicts. In a few days though, I'd really like to see what idiomatic Python 3.7 code would look like. I'm grateful for all tips/code reviews/suggestions!

kaegi commented 5 years ago

I've formatted the python files with black. If you want to clean up the code, feel free to do so!

CosmicHorrorDev commented 5 years ago

Sorry for the delay, somehow your reaponse slipped by me without a notification.

I've got a busy week ahead of me, but should have some time later this week to go over everything. Since these scripts seem to just be for developers are you fine with a minimal version of 3.6 or so?

kaegi commented 5 years ago

These scripts are solely for generating statistics in documentation/thesis.pdf. I'm done with them, but they might be interesting for other developers (I only used 118 subtitles in my thesis, it might be interesting to test with thousands of subtitles). I actually use python 3.7 - restrictions (python version, more dependencies, ...) are not a problem if that improves code quality.