kaelad02 / adv-reminder

Foundry VTT module to get advantage reminders for lots of d20 rolls
MIT License
6 stars 5 forks source link

[Feature request] Include messages in rolls affected by conditions #82

Open lucaspicerni opened 5 days ago

lucaspicerni commented 5 days ago

Hello!

Since the module already has the function of including advantage/disadvantage flags in the system status, it would be great if it also added messages to the affected rolls, something like "Disadvantage because you are Prone". I currently use both functions of the module simultaneously (advantage/disadvantage flags and message flags), because my players often forget everything, so the visual reminder always helps a lot! But I miss not having the messages in the rolls that are affected by D&D conditions.

In fact, it would be great if these messages could be translated along with the other module settings.

Edit: I know that the module already has the function to display the source of the advantage/disadvantage, but I believe that it becomes a bit redundant, when the message function is already in use. I describe pretty much everything in every roll, so with the source indication option, the roll box gets a bit cluttered. Maybe a solution would be to separate this configuration into two? "Display source of advantage/disadvantage for conditions" and "display source of advantage/disadvantage for other rolls"? But to be honest, I would really prefer the option to include messages in the conditions (which in turn would allow for personalization).

Finally, an extremely welcome bonus would be to send a warning in chat (or in the interface) when an auto-fail flag is active and the player clicks on the affected save!

Thank you very much!

kaelad02 commented 5 days ago

The module has a setting called Enable Condition Effects. It adds advantage/disadvantage to the system's conditions (e.g. disadvantage to attacks if you're Prone). If you also have the Show Sources setting enabled, it'll show that too (e.g. Disadvantage from Prone). It sounds like that will do what you want, or am I missing something?

lucaspicerni commented 5 days ago

Let me explain better: I currently use the messages provided by the module as a visual reminder for my players. Therefore, a typical roll at my table would look like this:

image

With the "Show Sources" option enabled, the same roll would look like this:

image

As you can see, it is redundant and visually polluted, there is no need to use this setting in my case, so I don't use it. But with this setting disabled, it is not possible to identify the source of the disadvantage/advantage, when it comes from a condition. What I would like the module to do would be to add messages (if possible with strings available for translation in the module files) to rolls affected by conditions, when the "Enable Condition Effects" setting is active, even if the "Show Sources" setting is disabled. Something like this:

image