No support for Krowi's Extended Vendor UI

[Ookami313]

Updated to 4.0.0, Upon logging into the game I get the following error. Thanks.

120x ...faceBuyEmAll/MerchantFrame/BuyEmAllFrame.lua:364: attempt to index local 'itemButton' (a nil value) [string "@BuyEmAll/MerchantFrame/BuyEmAllFrame.lua"]:364: in function BuyEmAllFrame_UpdateMerchantInfo' [string "@BuyEmAll/MerchantFrame/BuyEmAllFrame.lua"]:187: in functionBuyEmAllFrame_Update' [string "@BuyEmAll/MerchantFrame/BuyEmAllFrame.lua"]:87: in function <...faceBuyEmAll/MerchantFrame/BuyEmAllFrame.lua:79>

Locals: numMerchantItems = 0 name = nil texture = nil price = nil stackCount = nil numAvailable = nil isPurchasable = nil isUsable = nil extendedCost = nil currencyID = nil (for index) = 13 (for limit) = 30 (for step) = 1 i = 13 index = 13 itemButton = nil merchantButton = nil merchantMoney = nil merchantAltCurrency = nil (temporary) = "BuyEmAllItem13AltCurrencyFrame" (temporary) = "13" (temporary) = "AltCurrencyFrame" (temporary) = "AltCurrencyFrame" (temporary) = 0.400000 (temporary) = BuyEmAllItem12SlotTexture { } (temporary) = 0.400000 (temporary) = 0.400000 (temporary) = 0.400000 (temporary) = "attempt to index local 'itemButton' (a nil value)" MAX_MONEY_DISPLAY_WIDTH = 120

[fraerie]

I'm not usure if it's related to the above error - I've been getting spammed with the following error:

WARNING> code issue - function for [HookOpenAllBags:BuyEmAllFrame] was not found - please notify the author so it can be fixed.

[Odysseas68]

Same error in login with v4.0.0:

253x ...faceBuyEmAll/MerchantFrame/BuyEmAllFrame.lua:364: attempt to index local 'itemButton' (a nil value) [string "@BuyEmAll/MerchantFrame/BuyEmAllFrame.lua"]:364: in function BuyEmAllFrame_UpdateMerchantInfo' [string "@BuyEmAll/MerchantFrame/BuyEmAllFrame.lua"]:187: in functionBuyEmAllFrame_Update' [string "@BuyEmAll/MerchantFrame/BuyEmAllFrame.lua"]:87: in function <...faceBuyEmAll/MerchantFrame/BuyEmAllFrame.lua:79>

Locals: numMerchantItems = 0 name = nil texture = nil price = nil stackCount = nil numAvailable = nil isPurchasable = nil isUsable = nil extendedCost = nil currencyID = nil (for index) = 13 (for limit) = 20 (for step) = 1 i = 13 index = 13 itemButton = nil merchantButton = nil merchantMoney = nil merchantAltCurrency = nil (temporary) = "BuyEmAllItem13AltCurrencyFrame" (temporary) = "13" (temporary) = "AltCurrencyFrame" (temporary) = "AltCurrencyFrame" (temporary) = 0.400000 (temporary) = BuyEmAllItem12SlotTexture { } (temporary) = 0.400000 (temporary) = 0.400000 (temporary) = 0.400000 (temporary) = "attempt to index local 'itemButton' (a nil value)" MAX_MONEY_DISPLAY_WIDTH = 120

[kaelonR]

Thanks. Will look into this ASAP.

[kaelonR]

@Ookami313 @Odysseas68 This error seems to indicate that another addon has overriden the MERCHANT_ITEMS_PER_PAGE variable, which is normally 10. This in turn seems to indicate that there's an addon active which tries to trick the merchant frame into showing more items at the same time.

Can I get a list of addons you're using? especially anything related to merchants or bag inventory is interesting.

[Sookhaal]

Hi! I'm having the same problem, here are two addons that modifies the MERCHANT_ITEMS_PER_PAGE variable and cause an error: https://www.curseforge.com/wow/addons/krowi-extended-vendor-ui (this is the one I use personally) https://www.curseforge.com/wow/addons/elvui-windtools (the extend merchant pages setting in particular)

[kaelonR]

Hi! I'm having the same problem, here are two addons that modifies the MERCHANT_ITEMS_PER_PAGE variable and cause an error: https://www.curseforge.com/wow/addons/krowi-extended-vendor-ui (this is the one I use personally) https://www.curseforge.com/wow/addons/elvui-windtools (the extend merchant pages setting in particular)

Thank you.

I just fixed the error in v4.0.1, but the 'fix' here was to hardcode MERCHANT_ITEMS_PER_PAGE to 10 within the BuyEmAll context, so that the code won't attempt to set data in more than 10 buttons.

This means BuyEmAll currently has no support for Krowi's Extended Vendor UI, as BuyEmAll replaces the vendor UI.

I will look into adding support for Krowi's Extended Vendor UI in the near future.

[Odysseas68]

Also with this change if you set Krowi's Extended Vendor UI to bigger frame (double) BuyEmAll left an invisible frame. My KEVU setup: Rows 5 / Columns 4. If you click out of the vendor frame (right side) you will see that your character can't move. Also if you hover over the invincible area you will see and some tooltip's without the actual item :)

[kaelonR]

Should be fixed with v4.1.1 now.

[Sookhaal]

No more errors on my end, either using Krowi's Extended Vendor UI or windtool extend merchant pages feature.

Thanks for the fix 👍