search

kaelonR / WoW-BuyemAll-live

5 stars 6 forks source link

Patch 10.0.0 Compatibility Fix #4

Closed citreae535 closed 2 years ago

citreae535 commented 2 years ago

This one is compatible with patch 10.0.0 but not 10.0.2 because of Patch 10.0.2 API changes. That'll require another minor fix. The problematic <Backdrop> is removed in Patch 9.0.1 and does not seem to affect functionality anyway.

kaelonR commented 2 years ago

Hey, you're just a few minutes too late, as I published a new version of the addon to CurseForge and WoWInterface 25 minutes ago. Thank you for taking the time to look into these issues though :)

There was another issue as well, Some bagIDs were changed in Dragonflight (bags 1 through 4 had IDs 20-23 in Shadowlands, but are now 31-34 in Dragonflight) which threw off the "amount you can fit" calculation.

I've already fixed these issues and so sadly won't be merging your PR, but thank you for your effort anyway :)

As for the tooltip changes in 10.0.2: I sadly don't have access to the beta, which makes this hard to test. I'm afraid I'll have to wait until 10.0.2 launches to update tooltip-related code.