kaelri / enigma

A featured "suite" for the Windows system monitoring application, Rainmeter.
https://www.kaelri.com/project/enigma/
269 stars 93 forks source link

Update to Weather #116

Closed eclectic-tech closed 3 years ago

eclectic-tech commented 3 years ago

Changes to all weather related skins.

eclectic-tech commented 3 years ago

The update adds the latest JSON files by JSMorley, adds a new World page inc file in Options, and an updated WeatherCodeFinder.ini skin used for local and world weather location search and setting latitude/longitude, language, and units.

If things go as planned, please look it over and offer any suggestions on changes.

NOTE: I did not take advantage of your script to write changes done for weather, since I am not that proficient in lua. You might want to look at modifying how the world weather variables are updated (I used '!WriteKeyValue' directly).

Thanks, John Moran (eclectic-tech)

kaelri commented 3 years ago

I've seen your efforts on the Rainmeter forums toward maintaining & modernizing Enigma’s weather functionality, for which I am most grateful. :) I sadly don’t expect to have an opportunity to revisit Rainmeter development in the foreseeable future. In any case, this work can only improve the state of the skin and mitigate issues people are having, and I see no causes for concern at first glance. Merged into master.

eclectic-tech commented 3 years ago

Thanks. I understand how life's priorities can limit time available for 'hobbies'. You created a time-enduring suite which is my pleasure to help maintain. Being retired allows me to time to 'tinker' with code, without deadlines, and lets me decide on what things are deserving of it, like Enigma.

Have a safe and happy holiday season!