search

kaelzhang / shell-safe-rm

😎 Safe-rm: A drop-in and much safer replacement of bash rm with nearly full functionalities and options of the rm command! Safe-rm will act exactly the same as the original rm command.
Other
428 stars 33 forks source link

safe-rm stops working on Linux #25

Closed njZhuMin closed 3 years ago

njZhuMin commented 3 years ago

Hi @kaelzhang , Thank you for your great job done here! However recently I found safe-rm does not work anymore on Linux while it still works on my macOS.

Reproduction:

  1. Install $ npm i -g safe-rm $ alias rm='safe-rm' // added to ~/.zshrc since I am using zsh

  2. Make sure alias works $ alias // outputs: rm=safe-rm

  3. Test deleting $ touch a.txt $ rm a.txt // a.txt not found in Trash

$ touch a.txt $ safe-rm a.txt // a.txt not found in Trash

I also tried both zsh and bash, got the same result.

Please help check this out since it's really terrifying to find it not working anymore lol.

Thanks.

Env: OS: Manjaro 20.1.2 Mikah Kernel: x86_64 Linux 5.4.72-1-MANJARO Shell: zsh 5.8 Resolution: 3840x1080 DE: GNOME 3.36.4

njZhuMin commented 3 years ago

Not an issue. I created the alias, safe-rm binary does exist. But the node_modules/safe-rm were broken. So it didn't work. Surprised there is no error though /usr/lib/node_modules/safe-rm/bin/rm.sh does not exist :-)