Bad exit code (1) even though it succeeds and should be 0

kaelzhang / shell-safe-rm

😎 Safe-rm: A drop-in and much safer replacement of bash rm with nearly full functionalities and options of the rm command! Safe-rm will act exactly the same as the original rm command.

Other

428 stars 33 forks source link

Bad exit code (1) even though it succeeds and should be 0 #6

Closed asaf-erlich closed 6 years ago

asaf-erlich commented 10 years ago

To start my operating system is redhat 5 on a 64 bit virtual machine. I cloned the repository and built it.

How to reproduce: cd /tmp/ mkdir testdirectory rm -rf testdirectory echo $?

See it output 1

Uninstall safe-rm and you will see this should output 0. Furthermore, even though it reports a bad exit code of 1 it successfully removes the directory as it should.

kaelzhang commented 10 years ago

I'll take into this within the next 24 hrs

asaf-erlich commented 10 years ago

Thanks. No rush, though. I have uninstalled this for the time being since some scripts at work depend on the exit code and were failing. Thanks for looking into it.

-Asaf On Mar 22, 2014 5:04 AM, "Kael Zhang" notifications@github.com wrote:

I'll take into this within the next 24 hrs

Reply to this email directly or view it on GitHubhttps://github.com/kaelzhang/shell-safe-rm/issues/6#issuecomment-38349747 .

kaelzhang commented 6 years ago

Seems that the issue could be closed. Plz reopen if there are still issues