exit code fixed and -I option added

kaelzhang / shell-safe-rm

😎 Safe-rm: A drop-in and much safer replacement of bash rm with nearly full functionalities and options of the rm command! Safe-rm will act exactly the same as the original rm command.

Other

428 stars 33 forks source link

exit code fixed and -I option added #8

Closed bunop closed 7 years ago

bunop commented 8 years ago

Hi kaelzhang,

I've added some modification on your script. Briefly:

I've fixed the exit status on success (see this issue)
I've added the -I/--interactive=once for asking only one time before removal (see man rm for details)
The installation will not replace the default rm binary, I prompt a command to use safe-rm as an alias (see your issue)
Other minor fixes

Regards,

Paolo

kaelzhang commented 7 years ago

Sorry that I missed the pr for a long time.

bunop commented 7 years ago

No problem. There is another issue when you try to remove a soft link pointing to a directory. If I have time, I try to deal with it.

kaelzhang commented 7 years ago

That really helps 😄

I've changed the code style according to https://google.github.io/styleguide/shell.xml

Please git pull to get the latest commit head before anything.

bunop commented 7 years ago

I've described the link problem in #11 and proposed a PR #12 . Cheers.