Open queenvictoria opened 5 years ago
I intend to come back to this issue and submit a pull request if I have time.
I see that there is an outstanding issue for this in the upstream library https://github.com/dimsemenov/PhotoSwipe/issues/1503
We have the opportunity in this addon to fix this. The code is pretty straight forward. Within the empty button we include something like
<span class="sr-only" aria-hidden="true">Close slideshow</span>
And then in css
.sr-only { display: none; }
As I say--I'll circle back to this if I get time.
Also we probably need to support alt tags too. https://github.com/dimsemenov/PhotoSwipe/pull/1423
alt
Instead of the sr-only <span> we can do this:
sr-only
<span>
<button aria-label="Next"></button>
I intend to come back to this issue and submit a pull request if I have time.
I see that there is an outstanding issue for this in the upstream library https://github.com/dimsemenov/PhotoSwipe/issues/1503
We have the opportunity in this addon to fix this. The code is pretty straight forward. Within the empty button we include something like
And then in css
As I say--I'll circle back to this if I get time.