search

kaermorchen / twig-language-server

Language server for Twig templates.
Mozilla Public License 2.0
29 stars 3 forks source link

Support more lsp features #19

Open aszenz opened 1 year ago

aszenz commented 1 year ago

Thanks for making this and improving the lives of twig developers.

Before using the vscode plugin I used https://marketplace.visualstudio.com/items?itemName=mblode.twig-language-2.

I'm missing some feature from it though:

  1. Twig snippets like these 
    do                {% do ... %}
extends           {% extends 'template' %}
from              {% from 'template' import 'macro' %}
  2. Support formatting maybe integrate with third party plugin like prettydiff
  3. Some form of go-to-definition (maybe for blocks and macros initially)
kaermorchen commented 1 year ago

Did you try to use the both extensions together? They shouldn't conflict.

aszenz commented 1 year ago

Did you try to use the both extensions together? They shouldn't conflict.

Yes i could use the snippets from the library, and use this library for syntax highlighting

moetelo commented 1 year ago

@aszenz

Some form of go-to definition

Implemented that here for include('template.html.twig') and other template inclusion statements/functions. https://github.com/kaermorchen/twig-language-server/pull/27

Please tell me if something is missing for this feature. PR review is welcomed.