kaetemi / gdemu

Gameduino Emulator
3 stars 0 forks source link

does not compile on Linux Host #1

Closed gianlucarenzi closed 5 years ago

gianlucarenzi commented 5 years ago

Hello, I know this is a very old project, but I need to build up a Linux Gameduino v1 Emulator because I am building an hardware for retrocomputers to run gameduino on them, and for start I need a emulator on PC. When compiling it gives me an error on the min() and max() MACROS, giving those errors:

n file included from /usr/include/c++/8/bits/char_traits.h:39, from /usr/include/c++/8/string:40, from /home/debian/packages/gdemu/gdemu/gdemu_system_sdl.h:53, from /home/debian/packages/gdemu/gdemu/gdemu_graphics_driver_sdl.cpp:36: /usr/include/c++/8/bits/stl_algobase.h:243:56: error: macro "min" passed 3 arguments, but takes just 2 min(const _Tp& a, const _Tp& __b, _Compare comp) ^ /usr/include/c++/8/bits/stl_algobase.h:265:56: error: macro "max" passed 3 arguments, but takes just 2 max(const _Tp& a, const _Tp& __b, _Compare comp)

Can you help me out to solve those issues?

Regards,

kaetemi commented 5 years ago

In "wiring.h", remove the min/max definitions, maybe need to replace with using std::max; using std::min;

-- Jan Boon

On Mon, Oct 7, 2019 at 3:53 PM Gianluca GP Renzi notifications@github.com wrote:

Hello, I know this is a very old project, but I need to build up a Linux Gameduino v1 Emulator because I am building an hardware for retrocomputers to run gameduino on them, and for start I need a emulator on PC. When compiling it gives me an error on the min() and max() MACROS, giving those errors:

n file included from /usr/include/c++/8/bits/char_traits.h:39, from /usr/include/c++/8/string:40, from /home/debian/packages/gdemu/gdemu/gdemu_system_sdl.h:53, from /home/debian/packages/gdemu/gdemu/gdemu_graphics_driver_sdl.cpp:36: /usr/include/c++/8/bits/stl_algobase.h:243:56: error: macro "min" passed 3 arguments, but takes just 2 min(const _Tp& a, const _Tp& __b, _Compare comp) ^ /usr/include/c++/8/bits/stl_algobase.h:265:56: error: macro "max" passed 3 arguments, but takes just 2 max(const _Tp& a, const _Tp& __b, _Compare comp)

Can you help me out to solve those issues?

Regards,

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kaetemi/gdemu/issues/1?email_source=notifications&email_token=AAMB77ON3KHIHX7JFUNUGALQNLTHVA5CNFSM4I6A6FEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HP7R6OQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMB77LTIVUG6VSUFUT4FGDQNLTHVANCNFSM4I6A6FEA .

gianlucarenzi commented 5 years ago

On 10/07/2019 03:06 PM, Jan Boon wrote:

In "wiring.h", remove the min/max definitions, maybe need to replace with using std::max; using std::min;

Adding the following:

include // std::min

using std::max;

using std::min;

helps to build the library correctly.

Now I have some warnings/errors compiling some examples, but I do not care. The library seems to work with Asteroids, Boing Ball and others...

Cheers

-- Eurek s.r.l. | Electronic Engineering | http://www.eurek.it via Celletta 8/B, 40026 Imola, Italy | Phone: +39-(0)542-609120 p.iva 00690621206 - c.f. 04020030377 | Fax: +39-(0)542-609212