kaf-lamed-beyt
commented
1 year ago Hi @PrimeFord, This looks absolutely awesome! 💯
But, I noticed that you created 3 different Pull Requests. Now, there's nothing really bad about that, but, I noticed that you are bringing the commits from the previous branches you checked out from into the new branch — this one for example.
Take a look at the image below.
If you take a look at the "commits" tab of this Pull request, you'll notice that you have over 24 commits, which isn't too good. You're bringing the commit histories of the previous merge operations, your previous branches and this latest one together.
Now, merging this PR shouldn't be am issue as I'll just squash them into one commit. But, I think it may still affect the commit history of this project.
where to go from here?
I'd suggest that you close the PRs for Keras and Cybersecurity, then proceed to create separate PRs for them.
Or better still, just combine both fixes into one PR, because creating two separate PRs would necessitate you to wait for one to be merged before creating the next, to avoid merge conflicts.
Lastly, then checkout the master branch and try syncing your forked version so it is up to date with this repo, commit your changes if need be.
Them make the PR fixes and push.
PrimeFord
✅ Deploy Preview for ng-tech-events ready!
Toggle QR Code...
Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site configuration.