kafbat / helm-charts

Helm charts for kafbat projects
https://ui.charts.kafbat.io/
Apache License 2.0
6 stars 13 forks source link

More then one existing secret in the Helm chart options #10

Closed dimashenkov closed 6 months ago

dimashenkov commented 7 months ago

Issue submitter TODO list

Is your proposal related to a problem?

No response

Describe the feature you're interested in

For example I need to pass different secrets for SSO and for the Kafka cluster . Would be good to to change deployment.yaml in the Helm chart to be able to pass more then one existing secret in values.yaml, like this .

            {{- if .Values.existingSecrets }}
              {{- range .Values.existingSecrets }}
              - secretRef:
                  name: {{ . }}
              {{- end }}
            {{- end }}

Describe alternatives you've considered

No response

Version you're running

27c5e61

Additional context

No response

azatsafin commented 7 months ago

Could you please consider to use other tools to construct cumulative secret. The tools which can help with this: ClusterSecret, ExternalSecrets. Also please check kustomize secret generator, maybe it will suit your needs.

dimashenkov commented 7 months ago

to construct cumulative secrets is not that convenient but fine.

Haarolean commented 6 months ago

The problem with this approach is that changes like this will be breaking for the users who already use one secret as far as I understand it. However, we could accept PRs with the changes which are non-breaking. Feel free to raise one if you find it viable.