search

kafelez / jsendnsca

Automatically exported from code.google.com/p/jsendnsca
0 stars 0 forks source link

JSend NSCA should accept no password as valid which should also be the default #32

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
See 
http://groups.google.com/group/jsend-nsca/browse_thread/thread/cf8cb589a867f3b

What steps will reproduce the problem?
1. Install NSCA Daemon
2. Default nsca.cfg has password commented out as below

#password=

3. Default encryption method is XOR as per below

decryption_method=1

Currently, default password is "password"

If you try and set a password of "" or null, you get an IllegalArgumentException

Workaround is to set password of space (" ")

Original issue reported on code.google.com by rajneeshpatel on 21 Sep 2010 at 7:48

GoogleCodeExporter commented 8 years ago 
Code and tests commited, POM updated to version 2.0.1

Original comment by rajneeshpatel on 21 Sep 2010 at 8:11

GoogleCodeExporter commented 8 years ago 
New release 2.0.1 which fixes issue by

 * setting default password on NagiosSettings to empty string
 * removed check on setPassword method which checks for empty string or null
 * added withNoPassword method to NagiosSettingsBuilder to make it clearer if you are not setting a password

Original comment by rajneeshpatel on 22 Sep 2010 at 8:26