kaffa / textpattern

Automatically exported from code.google.com/p/textpattern
0 stars 0 forks source link

Proposed tweaks to en-gb.txt in RPC - part 1 #334

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi.
I've included some proposed changes to the en-gb.txt in RPC. They are minor and 
hopefully not contentious.

Background: http://forum.textpattern.com/viewtopic.php?id=39034

They're all being made to this repo: 
https://github.com/petecooper/txp-rpc-lang-en-gb <-- ignore everything before 
"Bump to 4.5.4;1353747915", commit ref 496e132ffd -- I was finding my feet a 
little.

- (gd_library) GD Image Library is actually called GD Graphics Library. Diff: 
https://github.com/petecooper/txp-rpc-lang-en-gb/commit/abcb7846406201e373e76fd3
06a126adf5e91c84
- (add_new_author) 'Add new author' is confusing in the User tab. 'Add new 
user' makes more sense, and considering not all users will have author rights, 
it's more accurate. Diff: 
https://github.com/petecooper/txp-rpc-lang-en-gb/commit/2c1eebedfb668fccc6a3caad
6e1b859f2872d138
- Changing 'e-mail' to 'email'. AP Style Guide now says 'email' (switched from 
'e-mail' in 2011), Yahoo! Style says 'email', Google says 'email', Brits say 
'email'. It should be 'email'. Diff: 
https://github.com/petecooper/txp-rpc-lang-en-gb/commit/50ab5c23380ab4a2f339b05c
75d043d9df91bc15

I have some additional things to propose, too, so please advise if this method 
of suggesting changes meets your requirements.

Original issue reported on code.google.com by gaek...@gmail.com on 5 Dec 2012 at 1:12

GoogleCodeExporter commented 8 years ago
Two more, then I'll stop for now:

- A few 'mail' to 'email' for consistency. Diff: 
https://github.com/petecooper/txp-rpc-lang-en-gb/commit/9f23865e3825115493f3463a
d490ee4d225577de
- 2x 'author' to 'user' changes. Diff: 
https://github.com/petecooper/txp-rpc-lang-en-gb/commit/0bb810979d755afff05338be
08d1fca44fc2411e

OK, done for now. I promise. Scouts honour.

Original comment by gaek...@gmail.com on 5 Dec 2012 at 1:21

GoogleCodeExporter commented 8 years ago
Looking good. I'm guilty of 'e-mail' (to fit with e-commerce, e-publishing, etc 
because I like the consistency it offers) but admit I'm a hyphenosaurus.

Author vs User has always been a contentious one because we don't have a 
<txp:user /> tag but we have <txp:author>. Like you say, not all users are 
authors (Designers for example, although they can Write I think?) and since 
most people in the front-facing world never see the tags, standardising on user 
and username makes sense.

They're all 'easy' edits to make, it's just a case of someone logging into the 
RPC server, hunting them down and changing them.

Original comment by stefdawson on 5 Dec 2012 at 2:28

GoogleCodeExporter commented 8 years ago
Thanks, Stef -- for completeness, is my approach here appropriate for the 
developer team workflow?

Original comment by gaek...@gmail.com on 5 Dec 2012 at 2:35

GoogleCodeExporter commented 8 years ago
Some additional Author -> User switches. Diff: 
https://github.com/petecooper/txp-rpc-lang-en-gb/commit/42e6e886a2ca687277a85a3c
264f7078bb578a7e

Original comment by gaek...@gmail.com on 5 Dec 2012 at 2:43

GoogleCodeExporter commented 8 years ago
I can't comment for the others, but it works for me. We have a clear history of 
changes, with reasons, in github and it's just a case of running through each 
diff, finding each string in the RPC quagmire, editing it and saving it.

Besides giving you a translator login to do the RPC changes yourself, I can't 
see any other way to approach it: the endpoint is always someone using the RPC 
interface to alter things by hand.

Not even sure if there is a translator account for en-gb -- never looked -- but 
I guess it's the same concept as the others so there's no technical reason 
there can't be one. Robert might be able to chime in on this one. There may be 
something special about the en-gb entries though: perhaps they email out 
changes to other translators to notify them that strings need updating. Dunno 
how it works.

P.S: note use of 'email' in this reply :-)

Original comment by stefdawson on 5 Dec 2012 at 2:44

GoogleCodeExporter commented 8 years ago
We can assign translator accounts to "en-gb" alike any other language. 

While using patches to en-gb.txt to convey string changes is a bit awkward in 
comparison to direct RPC access it surely suffices as long as it's just about a 
handful of changes as it is the case with the issue at hand.

Original comment by r.wetzlmayr on 5 Dec 2012 at 4:17

GoogleCodeExporter commented 8 years ago
Not so much Resolved as Reassigned. All language files are now publicly 
editable at https://github.com/textpattern/textpacks so community-driven 
changes to the language files are possible by simply forking the repository, 
making changes and issuing a pull request.

Going forward, the RPC server will have less of a role to play in string 
distribution.

Original comment by stefdawson on 21 Aug 2013 at 8:31