Open GoogleCodeExporter opened 8 years ago
Do you need any CSS created for this. I'd purposely left specific styling for
sortables out of the jQuery UI CSS file, because that interaction could be used
for all manner of things.
However, we can directly style the .txp-sortable within the admin themes
themselves if you need me to.
Original comment by flaming....@mac.com
on 27 Jan 2013 at 9:41
Yes, please. Sortables should be styled too.
Sortables are part of the jQuery UI specification, and as such they should be
styled and supported too. Nothing from jQuery UI can be left out.
As .txp-sortable goes, please avoid using it styling. Meaning it should not be
mentioned even once in any CSS file. It's just for binding and is not part of
jQuery UI itself.
When you do any styling for jQuery UI specific functionality, you will have to
use only the jQuery UI's own classes apart from when its entirely Textpattern
specific custom widget. None of our own classes or additions can be used for
any jQuery UI specific functionality; These would not comply the specification
and will not be compatible with any jQuery UI plugin. Making the jQuery UI
included dead weight and, well, sadly useless in which point we could as well
remove it from the core.
Anyhow, for sortables the selectors you will be able to target are:
- .ui-sortable
- .ui-sortable-disabled
- .ui-sortable-item
- .ui-sortable-helper
- .ui-sortable-placeholder
- [data-sortable-item]
For sortables you should avoid styles such as:
- Anything typeface and fonts
- Float, position, display
- Anything that affect sizes or page flow
- Cursors (interferes too much)
- Different box-sizing between different states and elements.
Safe styles are (but not necessarily limited) to:
- Background color
- Border color
- Font color
- Shadows
Furthermore with sortables there should be no ID dependencies within
".ui-sortable > element" (any IDs will have to be able to set freely for
children). jQuery UI uses IDs for serialization (detecting which item in the
sortable list is which).
Original comment by jukka.svahn@rahinaa.biz
on 27 Jan 2013 at 10:35
Probably the most common elements where '.ui-sortable' appears, and sortable
widgets are used, are 'ul', 'ol' and 'tbody'. Potential exceptions and more
specific styling could be created for at least '.txp-list > .ui-sortable'. When
you do style sortables, keep in mind that the UI widget supports nesting. If
you do any special styling, for example for tables, keep Mr. Chevron Key at
finger reach.
Original comment by jukka.svahn@rahinaa.biz
on 27 Jan 2013 at 10:45
Dumb multi-login resetting to the main Google account address, and dumb me not
noticing it before too late. Yup, the guy above is me, eh.
Original comment by jukka.m.svahn
on 27 Jan 2013 at 10:47
Original issue reported on code.google.com by
jukka.m.svahn
on 26 Jan 2013 at 2:55