search

kaffetorsk / arlo-streamer

Continuous stream for Arlo cameras
MIT License
30 stars 5 forks source link

Fixing ffmpeg crashes #15

Closed YpNo closed 8 months ago

YpNo commented 10 months ago

Fixing ffmpeg crashes in _start_stream function + Supporting HLS/Dash protocol Fix #13

kaffetorsk commented 10 months ago

Thanks for PR

Lot of changes here, can you describe what fail there is in _start_stream() and why?

PS: What kind of camera are you using?

YpNo commented 10 months ago

Explained in issue discussion.

I've used Arlo Pro 4 Cameras and 1 Arlo Doorbell essential.

YpNo commented 9 months ago

Hi, I reviewed my PR due to high cpu load because of ffpmeg video transcoding for the idle stream. I've reduce the modifications on ffpmeg options. I think the main issue have came from audio format.

YpNo commented 9 months ago

Hi @kaffetorsk,

Do you think we can merge this PR ? I saw you have closed the issue.

If you want to optimize what I did, please do :)

Regards

kaffetorsk commented 8 months ago

I'm rejecting this PR for several reasons:

  1. Too many changes that are somewhat randomly grouped together.
  2. When asked why you changed the ffmpeg params, the answer was basically that you just tried different combinations.
  3. I cannot replicate your issue, i don't think this repo is to blame, else other users would chime in
  4. FFMPEG version is set in order to support SRT.
  5. bsf dump_extra is needed to keep the proxy stream alive while switching pipe input.