search

kafka-ops / julie

A solution to help you build automation and gitops in your Apache Kafka deployments. The Kafka gitops!
MIT License
421 stars 114 forks source link

Update log4j in older major version branches #424

Closed DavidNavalho closed 2 years ago

DavidNavalho commented 2 years ago

Setting up an issue to request a bump of log4j in previous major versions, since some features have been deprecated or broken, and until migration can be made, it's important to get the log4j2 issues bumped

purbon commented 2 years ago

Thanks, David, quick question. 2.1.x is a really old version right now, anything preventing you to upgrade?

DavidNavalho commented 2 years ago

Mostly we have found that some features are currently deprecated in version 4, such as the ability to merge projects with the same name, and the cost of migrating everything into version 4 right now is prohibitive. Given the main rush right now is covering the log4j issues, this seems like the best approach.

Since it's also a quick and simple non-breaking change to 2.1.x, I figured this would buy us time to do a proper migration later on (there's a lot of naming conventions behind this)

purbon commented 2 years ago

Hi @DavidNavalho thanks for your feedback and prompt help to the project. It is highly appreciated.

As a note,

such as the ability to merge projects with the same name

this was not possible as well before, latest version just made it explicit. I would love to understand more what you mean here and try to find a way to help out.

In the meanwhile you will find latest related with your PR available https://github.com/kafka-ops/julie/actions/runs/1601063722 as well as in docker hub.

as soon as I can I will do an official release.

closing this for now, feel free to reopen in case of need.