search

kafka-ops / julie

A solution to help you build automation and gitops in your Apache Kafka deployments. The Kafka gitops!
MIT License
418 stars 113 forks source link

Extend ResourceFilter rules to be more precises for AccessControlManager (ACLs/RBAC) #521

Closed purbon closed 2 years ago

purbon commented 2 years ago

close #505

purbon commented 2 years ago

@sverrehu I add this to extend and amend the logic behind the ACLs/RBAC resource filter future. This is at request and started discussion with @ludovic-boutros and @damien-malescot in #505.

I add this PR to try to represent a proposed solution for this, if you get five minutes I would love your feedback here. Thanks a lot!!

purbon commented 2 years ago

@Fobhep and @akselh your thoughts are very much welcome as well! Thanks a lot for your continuous help with the project, this would not be a thing without your help.

sverrehu commented 2 years ago

I think it does what you outlined in the issue. LGTM.

purbon commented 2 years ago

Thanks for the feedback, and more importantly is this flow somehow resonable for you?

On Thu, 4 Aug 2022, 20:39 Sverre H. Huseby @.***> wrote:

I think it does what you outlined in the issue. LGTM.

— Reply to this email directly, view it on GitHub https://github.com/kafka-ops/julie/pull/521#issuecomment-1205630603, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQXPAQXDEHE3XKAHFJTBLVXQE5FANCNFSM55TF3EBA . You are receiving this because you authored the thread.Message ID: @.***>

purbon commented 2 years ago

merging this now, as it makes sense for #505 and others, we can always improve later on if required.