Implements optimized ACLs for subjects

kafka-ops / julie

A solution to help you build automation and gitops in your Apache Kafka deployments. The Kafka gitops!

MIT License

418 stars 113 forks source link

Implements optimized ACLs for subjects #528

Closed ludovic-boutros closed 2 years ago

ludovic-boutros commented 2 years ago

Please check if the PR fulfills these requirements
[x] The commit messages are descriptive
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[x] An issue has been created for the pull requests. Some issues might require previous discussion.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Fix #512

purbon commented 2 years ago

Hi @ludovic-boutros after merging your previous PR, now this has conflicts. Would you prefer to fix them yourself or want me to merge them manually? happy with both options 😄

purbon commented 2 years ago

Hi @ludovic-boutros I'm just going to merge it manually, I hope that is ok for you. Thanks again by all your efforts.

purbon commented 2 years ago

Manually merged d222e8366d7228a5f1e82534d940bd72e6202808, thanks a lot sir!

ludovic-boutros commented 2 years ago

Thanks @purbon !