kafka-ops / julie

A solution to help you build automation and gitops in your Apache Kafka deployments. The Kafka gitops!
MIT License
417 stars 113 forks source link

topic config retention erroneous update #538

Open tolikkk opened 1 year ago

tolikkk commented 1 year ago

On last 4.2 version (docker image 9a19aa1e2a7f) in dryRun execution I have updating retention.ms of all my topics to the same values. Without dryRun, everything is correct, no extra updates. On previous version 4.2.9 problem is absent, everything is correct at any execution type.

julie-ops-cli.sh --topology /topics.yml --brokers broker.example.com:9093 --clientConfig /config.properties --dryRun

12:36:44  {
12:36:44    "Operation" : "com.purbon.kafka.topology.actions.topics.UpdateTopicConfigAction",
12:36:44    "Topic" : "topic-test-1",
12:36:44    "Action" : "update",
12:36:44    "Changes" : {
12:36:44      "NewConfigs" : {
12:36:44        "retention.ms" : "2592000000"
12:36:44      }
12:36:44    }
12:36:44  }
12:36:44  {
12:36:44    "Operation" : "com.purbon.kafka.topology.actions.topics.UpdateTopicConfigAction",
12:36:44    "Topic" : "topic-test-2",
12:36:44    "Action" : "update",
12:36:44    "Changes" : {
12:36:44      "NewConfigs" : {
12:36:44        "retention.ms" : "1814400000"
12:36:44      }
12:36:44    }
12:36:44  }
...