Open Fobhep opened 1 year ago
@purbon can you review, please? We need this bugfix urgently, thanks.
I agree to this. The file will be sourced, and the set
commands will affect the user's shell. Also, the hash-bang line makes little sense for a file that must be sourced and not run directly. I suggest removing the first five lines completely.
Please check if the PR fulfills these requirements
[ x] The commit messages are descriptive
[ x] Tests for the changes have been added (for bug fixes / features)
[ x] Docs have been added / updated (for bug fixes / features)
[x ] An issue has been created for the pull requests. Some issues might require previous discussion.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix for #557
What is the current behavior? (You can also link to an open issue here) Prevents bash-script breaking user-sessions
What is the new behavior (if this is a feature change)? No set flags in bash script until properly reviewed