While you were gone... - Githubissues

sverrehu commented 1 year ago

Things that we already implemented where I work. Leaving it here in a multi purpose PR in case @purbon is interested at some time in the future. It's all in my main-sverrehu branch.

Update all dependencies to latest versions, including container versions in the code, and including rewriting now deprecated code.
Add a --recursive flag that allows finding topology files in subdirectories.
Remove the DEBUG logs that cluttered both test and run outputs.
Allow logging of INFO and above for AdminClient, instead of silencing it completely.
Replace the abandoned Java code formatter with the one from Spotify, which is up to date with Java 17.
Move ZooKeeper classes to src/test and mark the zookeeper dependency as test-scoped, since it was only used in tests, and dragged unwanted dependencies into the shaded jar. (These dependencies caused the spam of all kinds of DEBUG messages in the output.)

purbon commented 11 months ago

Thanks @sverrehu for your lovely work, while I'm kinda retired, @piotrsmolinski is helping out and he is preparing another PR, so love to get yours in. I hope that is ok for you.

sverrehu commented 11 months ago

Thanks @sverrehu for your lovely work, while I'm kinda retired, @piotrsmolinski is helping out and he is preparing another PR, so love to get yours in. I hope that is ok for you.

Of course, Pere!

purbon commented 11 months ago

Thanks again @sverrehu, merging this PR right now. @piotrsmolinski appreciate as well a ton your thoughts and help

kafka-ops / julie

While you were gone... #566