kafka-ops / julie

A solution to help you build automation and gitops in your Apache Kafka deployments. The Kafka gitops!
MIT License
417 stars 113 forks source link

Fix quota manager integration #581

Closed ludovic-boutros closed 7 months ago

ludovic-boutros commented 8 months ago

This fixes the integration and support of quotas in Julie Ops, including current state and deletion.

It does not work at all because the quota manager is not plugged and the data model does not contain quota declaration.

Quotas are supported for creation, current state and deletion with as usual a flag to allow deletion. No prefix management has been implemented because quotas are only using Users and therefore quotas should be declared in only one unique file.

No.

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines. IMPORTANT: Your pull request MUST target master.

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

sverrehu commented 6 months ago

This PR appears to have broken the unit tests, as it expects to find a broker on localhost:9092.

ludovic-boutros commented 6 months ago

This PR appears to have broken the unit tests, as it expects to find a broker on localhost:9092.

Indeed, I have created another PR to fix this #582. Any help is welcome 🙂

sverrehu commented 6 months ago

I replied in your other PR.