Closed ludovic-boutros closed 4 months ago
This still breaks the unit tests. There is no broker at localhost:909x when unit tests are run. Maybe you could disable your functionality during dry-run, if that makes any sense? The failing tests have dry-run enabled.
Other Manager
s have logic for not querying the cluster in certain cases, and this is used during unit testing. See e.g. ArtefactManager and TopicManager, which both have loadActualClusterStateIfAvailable
methods. On the other hand, QuotasManager
will always query the cluster.
I needed to add the quota manager mocks in the cli unit tests. I hope it should be good now.
…port
Please check if the PR fulfills these requirements
[x] The commit messages are descriptive
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] An issue has been created for the pull requests. Some issues might require previous discussion.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This PR fixes the CLI integration tests, broken since the quotas fix #581.
What is the current behavior? (You can also link to an open issue here) Timeout during integration tests.
What is the new behavior (if this is a feature change)? Tests should pass now.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines. IMPORTANT: Your pull request MUST target
master
.PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING