kafka-ops / julie

A solution to help you build automation and gitops in your Apache Kafka deployments. The Kafka gitops!
MIT License
417 stars 113 forks source link

Fix: CLI integration tests do not use correct credentials and broker port #582

Closed ludovic-boutros closed 4 months ago

ludovic-boutros commented 6 months ago

…port

No.

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines. IMPORTANT: Your pull request MUST target master.

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

sverrehu commented 6 months ago

This still breaks the unit tests. There is no broker at localhost:909x when unit tests are run. Maybe you could disable your functionality during dry-run, if that makes any sense? The failing tests have dry-run enabled.

Other Managers have logic for not querying the cluster in certain cases, and this is used during unit testing. See e.g. ArtefactManager and TopicManager, which both have loadActualClusterStateIfAvailable methods. On the other hand, QuotasManager will always query the cluster.

ludovic-boutros commented 4 months ago

I needed to add the quota manager mocks in the cli unit tests. I hope it should be good now.