kafkaesque-io / pulsar-helm-chart

Helm Chart for an Apache Pulsar Cluster
https://helm.kafkaesque.io
Apache License 2.0
31 stars 22 forks source link

change update to comply with golang 1.14 improvement #74

Closed zzzming closed 4 years ago

zzzming commented 4 years ago

To address https://github.com/kafkaesque-io/pulsar-helm-chart/issues/71 and https://github.com/kafkaesque-io/pulsar-helm-chart/issues/72

Since go 1.14 has introduced new error reporting of a parenthesized argument used as a function, described at https://golang.org/doc/go1.14, the template file needs to be updated.

The text/template package now correctly reports errors when a parenthesized argument is used as a function. This most commonly shows up in erroneous cases like {{if (eq .F "a") or (eq .F "b")}}. This should be written as {{if or (eq .F "a") (eq .F "b")}}. The erroneous case never worked as expected, and will now be reported with an error can't give argument to non-function.

helm3.4 is based on go1.14.10. This is how the problem were found with helm3.4 installation