search

kafkaex / kafka_ex

Kafka client library for Elixir
MIT License
596 stars 162 forks source link

Use offset_fetch api_version when fetching messages #450

Closed GDegrove closed 2 years ago

GDegrove commented 2 years ago

When switching to the new kayrock client, we noticed that the api_version for the auto_commit of the fetch message is not taken into account. Therefore, even if using the API version 2 for the offset commit with kayrock, the next fetch will always use the api_version 0

This introduces a divergence in the way the new client can be used compared to the old implementation. As it's up to the user code to provide the correct offset to fetch.

sourcelevel-bot[bot] commented 2 years ago

Hello, @GDegrove! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

jbruggem commented 2 years ago

Thanks a lot @bjhaid !