kafkaex / kafka_ex

Kafka client library for Elixir
MIT License
596 stars 162 forks source link

[Kayrock Sample] Kayrock migration phase one #477

Closed Argonus closed 1 year ago

Argonus commented 1 year ago

DO NOT MERGE

The first part of moving KafkaEx closer to v1.0.0

PR Content

Overview

Code & Tests Refactoring Some parts of the code could be easier to understand. Let's clean them up.

API implementation I've used protocols to mimic Factory patterns that can build & request & respond depending on input parameters.

Dependencies

Github Actions Improvements

Checklist

What's Next

To reviewers

Ok, this one is huge. Sorry about that, but I wanted to show you my idea, and I needed to show a bigger picture. Please review, comment & discuss. I currently have enough free time to push kafka_ex to v1.0.0. My idea is to create a branch release-v1 in the kafka_ex repo and create PR there. Then I'll be able to make smaller PRs for you to review.
And once all is migrated, we can do one big PR with cleanup and merge it to the master.

To Discuss

Argonus commented 1 year ago

I'm closing this PR as I'm going to deliver it in smaller more readable batches.