search

kafoso / doctrine-firebird-driver

Firebird driver for the Doctrine DBAL/ORM
MIT License
14 stars 16 forks source link

Composer extension requirement #1

Closed rogeriolino closed 5 years ago

rogeriolino commented 5 years ago

Add ext requirement on composer.json.

Example:

ext-interbase: "*"
kafoso commented 5 years ago

Thanks for the heads-up. It of course needs to be there.

I'll add it in a minor version.

kafoso commented 5 years ago

Coming to think of it, adding it to require will demand that a host OS has the extension installed. That's not a limitation that I want to impose.

It effectively means it'll become uninstallable through composer on the host OS when running composer install without --ignore-platform-reqs. Said option shouldn't be utilized unless you really know what you're doing.

It might only - in a development context (i.e. not production, staging, or test) - be needed in a VM guest OS (e.g. Docker, Vagrant, or XAMPP). Similar to how the test suite in this library is installed through a Vagrantfile.

I've added the following to README.md under Requirements:

ibase PHP extension (http://php.net/manual/en/book.ibase.php). Only needed on guest OS, e.g. a VM installed through Docker, Vagrant, or XAMPP.

d7b6d483d94a53e2461c973099b372c12cdcd729

Will be released with the next version.