kafoso / doctrine-firebird-driver

Firebird driver for the Doctrine DBAL/ORM
MIT License
14 stars 16 forks source link

Implementing with PDO backend. Fixes #9 #10

Closed rimas-kudelis closed 2 years ago

rimas-kudelis commented 4 years ago

This (hopefully) fixes #9, albeit with some caveats. Quoting the README, here are the missing features:

I also removed some assertions about internal class architecture from the tests. Swapping the backend ruined those assertions. I think we're supposed to test how the unit works, as opposed to how it is constructed.

rimas-kudelis commented 4 years ago

BTW I also merged your 2.7 branch back into master. Also, 52cf95a might be worth cherry-picking into 2.7 as well, since you broke symlinks you had committed previously. Although I don't think you should even commit them: they seem to be created automatically during composer install.

rimas-kudelis commented 2 years ago

The PR was closed because I deleted my fork, but I think you can still reopen it if you feel like it.