search

kafoso / doctrine-firebird-driver

Firebird driver for the Doctrine DBAL/ORM
MIT License
14 stars 16 forks source link

Missing checkLastApiCall() #4

Closed e-belair closed 5 years ago

e-belair commented 5 years ago

In case of sql error, i get the folling error: Call to undefined method Kafoso\DoctrineFirebirdDriver\Driver\FirebirdInterbase\Statement::checkLastApiCall()

e-belair commented 5 years ago

I've made Connection::checkLastApiCall() public Then I've modified Statement class, see my pull request...

kafoso commented 5 years ago

Great. Looks good at first glance. I'll check it later and ensure tests run correctly + add tests for the cases you've covered in PR https://github.com/kafoso/doctrine-firebird-driver/pull/5.

kafoso commented 5 years ago

PR https://github.com/kafoso/doctrine-firebird-driver/pull/5 has been merged.

I have, as mentioned, slightly improved exception handling and added more test coverage. See 20976ba33c485069beebb4a31b61425882195978.

There's a new release: 2.6.1

Thanks for your contribution.