kagesenshi / gnome-shell-extensions-pidgin

115 stars 73 forks source link

Add support for "Notifications Alert" extension #24

Closed bellini666 closed 12 years ago

bellini666 commented 12 years ago

Hi, I'm the developer of "Notifications Alert" extension < https://extensions.gnome.org/extension/258 >.

Some users reported me that our extensions isn't working together. It would be great if they worked, right? :) So, here is what my extension does: 1- It monkey-patch 'Source._setCount' and 'Source._destroy' to check for notifications. The original function is called them. 2- The check for notifications is done by: It search in 'messageTray._summaryItems' and see if each 'item.source._counterBin' has a visible property set and the counter isn't '0'. 3- If any of the counters exists and isn't '0', it paints red the message on user's menu, otherwise, it removes the red style.

Knowing that, if your extension uses that api, "Notifications Alert" should be aware of your new notifications too. I took a fast look at your code, and didn't see yet what is wrong. You are extending 'Source' and not overwriting '_setCount' or something like that. Maybe it's just a little thing missing, like adding the summaryItem at 'messageTray._summaryItems' or something like that.

bellini666 commented 12 years ago

I was taking a look at the source code again. Maybe this has something to do with you overwriting _init on Souce and not calling it's original method.

All the logic that I explained above is done here: https://github.com/hackedbellini/Gnome-Shell-Notifications-Alert/blob/master/extension.js#L66 And the monkey patchs here: https://github.com/hackedbellini/Gnome-Shell-Notifications-Alert/blob/master/extension.js#L117

Hope I could provide you enough information for the integration. If you need something else, just ask! :)

bellini666 commented 12 years ago

Forget it. The user who reported the issue to me said everything was a problem of an icon theme he uses. Closing the issue now. Sorry for disturbing.