kagesenshi / gnome-shell-extensions-pidgin

115 stars 73 forks source link

Update to work with Gnome Shell 3.6 #33

Open ghost opened 12 years ago

ildar commented 12 years ago

olibjerd, why this commit? it doesn't fix anything.

l300lvl commented 12 years ago

Just changing the version does not make this work with 3.6:

JS LOG: Extension "pidgin-conversation-integration@kagesenshi.org" had error: Error: No JS module 'telepathyClient' found in search path

kagesenshi commented 12 years ago

i'm not on gnome 3.6 yet .. but from what l300lvl mentioned .. got a feeling that this plugin might need a major update ..

js module telepathyClient no longer around? >.<

l300lvl commented 12 years ago

Well after looking closer the location has changed:

const TelepathyClient = imports.ui.telepathyClient;

becomes

const TelepathyClient = imports.ui.components.telepathyClient;

so it isn't gone and with this change the extension does enable, but it doesn't work, and there are other major changes to the module which need worked out

kagesenshi commented 12 years ago

ah ok then .. thanks l300lvl ..

i'll poke on this once i'm on Fedora18beta/gnome3.6 ..

F18beta should be out around end of this month ..

rajeshksv commented 12 years ago

Thanks for looking into this. Waiting for your extension to work in gnome shell 3.6 :)

boypt commented 12 years ago

I dig into the source and work out a merely working version at my fork, not perfect at all, and only works for 3.6(considering those grate changes brought by upstream api.)

https://github.com/pentie/gnome-shell-extensions-pidgin/commit/6d9690d3e5b34f5f1c019d6e8f136d839816e0a7

boypt commented 12 years ago

update those ICON thing. https://github.com/pentie/gnome-shell-extensions-pidgin

The gnome-shell code is too complicated, i don't know how to pull avatar from pidgin, I let it be the default one.

The unread counter not working (yet)

And My version ONLY works for 3.6, thus I think not to pull request to @kagesenshi at the moment, it's better to branch them in the repository, the 3.6 API changes and it's difficult to make it work with all versions.

olebowle commented 11 years ago

@pentie works for me for now, thanks a lot

alcuadrado commented 11 years ago

any news @kagesenshi ? I really love this extension

marcelometal commented 11 years ago

try to use this fork => https://github.com/thedeadparrot/gnome-shell-extensions-pidgin/commits/master

aL3xa commented 11 years ago

@marcelometal why don't you send a pull request or something? This definitely works!


EDIT

When you type in the message in the popup, it's not marked as read, hence notification icon ain't updated (keeps blinking). Which is a bugger. =/

olebowle commented 11 years ago

@pentie Unfortunately I can't open issues on your forks page, that's why I'm putting it here. I updated to gnome3.8 today. Your fork won't start even though I changed the shell-version in metadata.json to 3.8. The error message is: Error: No JS module 'dbus' found in search path

kagesenshi commented 11 years ago

seems like i myself havent got around to fix this .. too busy with work Plone stuff ..

any of the forks are working well? .. i can give direct access to here if there are people who are interested in continuing maintaining this ..waiting for me might take a too long ..

boypt commented 11 years ago

@olebowle I'm in gnome-shell 3.8 too but, I switched to empathy which I find had done a lot of improvement, it's more usable then ever.

The gnome-shell API is changing so much and the document is scarce, it's too harsh for me to keep this plugin working.

Hope someone else would do that ... :)

olebowle commented 11 years ago

I was hoping for the same. ;-)

l300lvl commented 11 years ago

As for the dbus stuff a quick google revealed it has some big changes in 3.8, hopefully this may be of some help: https://github.com/aleho/hamster-shell-extension/commit/8b4ba78c5abe6616cbf68c82736d4898e9e2373c

kagesenshi commented 11 years ago

yeah .. every release the API for the TelepathyClient notification changed .. :( ..

probably this plugin need a new rewrite, so that it doesnt rely on TelepathyClient stuff ..

Psykar commented 11 years ago

Why did I only read this comment thread AFTER my pain of getting this 3.8 ready. It's in a separate pull request, but I haven't tested with 3.4 or 3.6.