fix: Add Automatic-Module-Name attribute to jar manifests for better Java 9+ JPMS compatibility

peter277 commented 5 months ago

Add Automatic-Module-Name attribute to jar manifests for better Java 9+ JPMS compatibility. Affects: db-scheduler and db-scheduler-boot-starter.

Naturally the automatic module names I have entered are suggestions - please amend if required.

Fixes

Maven warning when compiling modular project: Required filename-based automodules detected: [db-scheduler-13.0.0.jar]. Please don't publish this project to a public artifact repository!

Reminders

[ ] Added/ran automated tests
[ ] Update README and/or examples
[x] Ran mvn spotless:apply

cc @kagkarlsson

kagkarlsson commented 3 months ago

I had to disable this again for the spring-boot-starter module due error when building. Have not had time to investigate, but I have added javadoc+sources to the CI-verification to catch it before merge.

kagkarlsson commented 3 months ago

See #498

kagkarlsson commented 3 months ago

🎉 This issue has been resolved in v14.0.1 (Release Notes)

kagkarlsson / db-scheduler

fix: Add Automatic-Module-Name attribute to jar manifests for better Java 9+ JPMS compatibility #477

Fixes

Reminders