search

kagof / intellij-pokemon-progress

A Pokémon themed progress bar for IntelliJ IDEA.
https://plugins.jetbrains.com/plugin/15090-pokemon-progress
MIT License
196 stars 22 forks source link

Feature/20 #21

Closed Paola351 closed 3 years ago

Paola351 commented 4 years ago

Closes Issue #20

Paola351 commented 4 years ago

Please, if you can, add the label hacktoberfest-accepted when you'll merge this :D

Paola351 commented 4 years ago

Hi @Paola351, thanks a lot for the PR!

The editSprite.sh script can be used to resize the larger sprites (Kyogre, Groudon, Rayquaza, Deoxys) down so they'll fit a bit better.

For example, with groudon: ./editSprite.sh groudon 32 makes it a more appropriate size.

Could you resize those sprites so they will fit in the progress bar? Ideally, there should be no part of the sprites that overlap the edge of the progress bar.

Also, as a bit of a nitpick, could you please move the Jirachi sprite 1 pixel to the right, and 1 pixel down? That way none of the progress bar colour shows in front of the sprite

Deoxys is already 32x32, I'll apply the changes you requested to the other pokemons :D Due some errors i use the ezgif size who uses ImageMagik to resize thos gifs and not the scripts :S hope it's not a problem

Paola351 commented 4 years ago

please @kagof let me know it there's something else i can do (if everything is ok, please label the PR with hacktoberfest-accepted)

Paola351 commented 4 years ago

Hi @Paola351, sorry for the belated review here, I've been away.

I think some clarification is needed RE gif sizing - although the gifs used in the plugin are generally 32x32 pixels, the actual space we have to work with in the progress bar is a bit smaller - the height of the progress bar is closer to 18px. So for sprites of smaller Pokémon (eg Jirachi), they fit fine as the full 32 pixels isn't utilized. However for Deoxys, some of the Pokémon is cut off, as you can see in this screenshot: Screenshot 2020-10-17 at 20 58 55

The editSprite.sh script I've created lets you "shrink" the sprite, then pad the border to make it 32x32 again. So, for example, I've done this with Blastoise, which is why the gif looks sort of blurry:

I'm not sure what the errors are that you're getting with the editSprite.sh script - we could potentially try to work through them and get the script working for you, or you could try to find an alternative to it.

As far as the other sprites go:

  1. Kyogre isn't even showing up for me: possibly shifted off of the drawing area entirely? Screenshot 2020-10-17 at 21 17 14
  2. Groudon is almost not visible: Screenshot 2020-10-17 at 20 56 18
  3. Rayquaza is also not showing up for me, again possibly shifted off of the drawing area entirely? Screenshot 2020-10-17 at 21 21 32
  4. Jirachi could be shifted down and to the right, see currently: Screenshot 2020-10-17 at 21 05 47 vs desired: Screenshot 2020-10-17 at 21 06 39

Is there anyway i can see the loading panel without installing the plugin? I use intellij idea 2019.3.4. I'll try to solve the problem you described.

Paola351 commented 4 years ago

@kagof I fixed the comments