kagof / intellij-pokemon-progress

A Pokémon themed progress bar for IntelliJ IDEA.
https://plugins.jetbrains.com/plugin/15090-pokemon-progress
MIT License
192 stars 21 forks source link

Possibility of having multiple themes for the gradient #59

Closed chylex closed 2 years ago

chylex commented 2 years ago

Current behaviour (optional)

There are some options to change the look, but none that affect the color gradient.

Description of the desired feature (required)

Since there are many possibilities of how the gradient could look, there could be a drop-down with a few predefined themes.

Why this feature would be valuable (optional)

Purely personal choice of aesthetics.

Additional information or context (optional)

I experimented with what looks I would prefer personally, and came up with a "Dark Flat" theme that uses the dark color of the types:

obrazek

Another option could be just "Flat" that uses the middle color:

obrazek

or "Light Flat":

obrazek

kagof commented 2 years ago

Hi @chylex, I'd be OK with adding these options. Are you willing to open a PR to add these options?

A couple of notes, I'd like the current gradient to remain the default. Likely a good place to add the drop-down would be in the checkboxPanel (along with a sensible rename 😅) unless you can think of a better spot.

chylex commented 2 years ago

Sure, I can add a drop-down with the current style and my 3 new styles, and submit a PR.

When I was experimenting with this, I also thought about adding a way to quickly cycle through a bunch of different Pokémon, to see how each style looks with different types - what do you think about a button in the Settings that randomly changes currently shown Pokémon? If that sounds good, I could include it in the PR, or open a new issue for it. I'm not sure what'd be a good spot for it though.

kagof commented 2 years ago

Could that maybe be added to or replace the preview panel on the configuration page?

Screenshot Preview

It could be a "refresh" or "randomize" button on that panel.

Perhaps it would be better to do that as a separate PR if it isn't too much extra work, just to keep this ticket pared down to only what is relevant to it.

chylex commented 2 years ago

Yea, I'll implement it separately and open a new issue with screenshots of how it looks before I PR it.

kagof commented 2 years ago

Perfect, thank you!

kagof commented 2 years ago

added in 1.7.0