CalendarGetDate throws nil-value error when trying to export lists or item history in WoW classic.

[ghost]

Whenever I try to export the item history on KSK, I get the following error:

Date: 2019-12-05 20:56:56
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\KKonferSK\KSK-Loot.lua line 1966:
   attempt to call global 'CalendarGetDate' (a nil value)
Debug:
   KKonferSK\KSK-Loot.lua:1966:
      KKonferSK\KSK-Loot.lua:1908
   KKonferSK\KSK-Loot.lua:3380:
      KKonferSK\KSK-Loot.lua:3379
   (tail call): ?
   [C]: ?
   [string "safecall Dispatcher[4]"]:9:
      [string "safecall Dispatcher[4]"]:5
   (tail call): ?
   KKonferSK\KKore\KKoreUI.lua:246: Throw()
   KKonferSK\KKore\KKoreUI.lua:1885:
      KKonferSK\KKore\KKoreUI.lua:1884
Locals:
None
AddOns:
  Swatter, v8.2.6377 (SwimmingSeadragon)
  AtlasLootClassic, vv1.3.3
  AtlasLootClassicData, vv1.3.3
  AtlasLootClassicDungeonsAndRaids, vv1.3.3
  AucAdvanced, v8.2.6430 (SwimmingSeadragon)
  AucFilterBasic, v8.2.6364 (SwimmingSeadragon)
  AucScanData, v8.2.6365 (SwimmingSeadragon)
  AucStatHistogram, v8.2.6366 (SwimmingSeadragon)
  AucStatiLevel, v8.2.6370 (SwimmingSeadragon)
  AucStatPurchased, v8.2.6367 (SwimmingSeadragon)
  AucStatSimple, v8.2.6399 (SwimmingSeadragon)
  AucStatStdDev, v8.2.6369 (SwimmingSeadragon)
  AucUtilFixAH, v8.2.6371 (SwimmingSeadragon)
  BeanCounter, v8.2.6434 (SwimmingSeadragon)
  CharacterStatsClassic, v2.4.2
  DBMCore, v1.13.18
  DBMDefaultSkin, v
  DBMStatusBarTimers, v
  Details, v
  DetailsTinyThreat, v
  Enchantrix, v8.2.6428 (SwimmingSeadragon)
  EnchantrixBarker, v8.2.6469 (SwimmingSeadragon)
  GatherMate2, v1.45.5
  GuildRosterManager, v1.831
  HealCommClassic, v
  Informant, v8.2.6374 (SwimmingSeadragon)
  KKonferSK, v6
  NeatPlates, v1.13.2.43
  NeatPlatesAlvara, v5a
  NeatPlatesBlizzardPlates, v1.5
  NeatPlatesClassicPlates, v
  NeatPlatesGraphite, v
  NeatPlatesGrey, v
  NeatPlatesNeon, v
  NeatPlatesQuatre, v
  NeatPlatesRenaitre, vv7.0.3
  NeatPlatesRoth, v
  NeatPlatesSimple, v7.3.0
  NeatPlatesSlimHorizontal, v2.2
  NeatPlatesSlimVertical, v2.2
  NeatPlatesHub, v
  NeatPlatesWidgets, v
  Questie, v5.2.1
  ShowMeMyHeal, v0.6.0
  SlideBar, v8.2.6375 (SwimmingSeadragon)
  Stubby, v8.2.6376 (SwimmingSeadragon)
  VendorPrice, v1.2.1
  BlizRuntimeLib_enUS v1.13.2.11302 <none>
  (ck=605)

I looked in the code and realised that this issue was prevalent wherever the lists are exported, or where the item history is exported. After searching the code for a while with a friend we found references to a different function for accesing date, we've applied those everywhere we saw calls to 'CalenderGetDate()' just as a temporary fix. The solution seems to allow me to export a valid XML string for the list and item history exporting.

[ghost]

I also applied these changes to a clone of the git repo locally, I have made a branch from r7. If you want these changes I can upload them.

[jkj]

Thank you kindly - I have already fixed this in my working tree (I noticed it myself) which will be released sometime soon. I must be honest I am glad someone is using the export functions at all - not many do :) Please keep bug reports and fixes coming they are highly appreciated.

On Fri, Dec 6, 2019 at 12:19 AM A. Masimba Walker notifications@github.com wrote:

I also applied these changes to a clone of the git repo locally, I have made a branch from r7. If you want these changes I can upload them.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kahluamods/konfersk/issues/2?email_source=notifications&email_token=AAC33GJ23U7U3ZZJJ26ZGD3QXF46BA5CNFSM4JWC7I7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGCLDHA#issuecomment-562344348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC33GO3GTN4RDYWTTW5BATQXF46BANCNFSM4JWC7I7A .

[ghost]

My guild have found a few more bugs, however I haven't been able to debug them. I can raise them as git issues if you feel that is appropriate?

[jkj]

Here is fine. I am not used to looking on GitHub.

On Friday, December 13, 2019, A. Masimba Walker notifications@github.com wrote:

My guild have found a few more bugs, however I haven't been able to debug them. I can raise them as git issues if you feel that is appropriate?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kahluamods/konfersk/issues/2?email_source=notifications&email_token=AAC33GNLVHWDO4DGPSTGE23QYORORA5CNFSM4JWC7I7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG2IJCQ#issuecomment-565478538, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC33GLIC7AOE2VG2YPM3YLQYORORANCNFSM4JWC7I7A .