kahluamods / konfersk

Suicide Kings loot distribution system
Apache License 2.0
1 stars 9 forks source link

Add an option to allow bidding on certain items below the bid threshold #5

Open praxxis opened 4 years ago

praxxis commented 4 years ago

Our guild sets the Bid/Roll threshold to epic, and gives all other blues/greens to the ML to DE for guild funds. With AQ coming out we wanted to be able to use KSK to roll on the new AQ mounts and enchants. I've added an option to allow items below the bid threshold to be rolled on if that item exists in the loot list. This lets us add the bugs and enchants in as loot and have KSK pop up when they drop.

jkj commented 4 years ago

Thank you so much for this work. I like the idea but I would implement it quite differently. Rather than having a global option (which isn't synced BTW) I would make it a per-item option, titled something like "Always Bid on Item" and make it an attribute of a stored item (which IS synced). It's a little bit more work (you will also have to change the CHITM message) but I think gives a better user experience. Then when we populate the loot list, we check each item to see if its in the items database, and if that option is set, add the item to the loot list for bidding. Bonus points if you make the other options and this new one behave correctly (eg if this is set, the "always assign to enchanter" shouldn't be, etc).

If you are up to it that would be great. If not let me know and I will do it for the next release.

praxxis commented 4 years ago

Makes sense, I can probably get that done.

Speaking of next releases, a wishlist item for us would be a bulk item import, maybe similar to TSMs import. I wrote a script that parses a CSV and outputs LUA to insert into the config lua but that's obviously less user friendly than a UI option :D

jkj commented 4 years ago

Cool let me know if you need any guidance / help / clarification of ideas.

As for the bulk import, I am less in favour of that for the simple reason that it is ONLY valuable to 1 person in a guild - everyone else gets the stuff synced so its only saving one person any real work. I am resistant to the idea of having everybody carry around code that will only really benefit one person, and even then , that benefit is very rare. New content patches where you would NEED a mass import only ever really come along twice a year at MOST, sometimes only every 18 months to 2 years or so. While you may be feeling the frustration right now because of AQ[24]0, I just don't think it would benefit enough people to justify the cost of having to maintain it forever more.

You will notice this is a theme with KSK. There is actually very little extra for an admin that doesn't also benefit normal users. At least that's what I strive for :)