kahole / edamagit

Magit for VSCode
https://marketplace.visualstudio.com/items?itemName=kahole.magit
MIT License
1.14k stars 67 forks source link

Diff line background colours #119

Open mattcopas opened 3 years ago

mattcopas commented 3 years ago

Would it be possible to have background colours for diffs, as in the below screenshot?

image

In some color schemes it can be quite hard to immediately see whats been added/deleted in a diff so this'd be really helpful.

This screenshot also shows specific words being highlighted - I'm only referring to the background colour of the whole line in this issue - I know there's another issue for word based diff.

Loving the plugin by the way!

kahole commented 3 years ago

Related #117 and #111

Goal is to use an enhanced diff view, in some way.

kahole commented 3 years ago

Branch tracking this work https://github.com/kahole/edamagit/tree/feature/strongerDiffHighlighting It's hit a bit of a dead end though

glasser commented 3 years ago

I'm here looking for a similar question, though mostly what I'm curious about is getting background colors on the @@ lines. In magit in my setup (I think the default) those have a grey background that makes them clearly different from other code, and something like that would be better than this:

image

That said I'm super excited to discover this plugin. My TypeScript workflow lately has been "use vscode for everything except Magit" and it would be nice to not be switching back and forth constantly!

kahole commented 3 years ago

@glasser Some themes, like Dracula, have the @@ lines in a different color. However, I see what you mean and I would like it clearer as well. This will be part of the bigger diff highlight improvements 👍 When there is a breakthrough there

dandavison commented 3 years ago

I also got here because I would like background colors on the @@ lines to make them stand out more, and was searching for existing issues. I know there's no disagreement here on desirability, but here's a screenshot making the point just in case it's helpful:

Edamagit Magit
image image